Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize: optimize client class or datastruct, read wait-free #127

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Optimize: optimize client class or datastruct, read wait-free #127

merged 1 commit into from
Apr 16, 2024

Conversation

helloopenworld
Copy link
Contributor

  • add lightly concurrent hashmap
  • GetProxy read wait-free
  • fiber transport ConnectorGroupManager read wait-free

@helloopenworld
Optimize: optimize client class or datastruct, read wait-free
ab4e296 
- add lightly concurrent hashmap
- GetProxy read wait-free
- fiber transport ConnectorGroupManager read wait-free
@codecov Codecov
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 83.71041% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 81.65658%. Comparing base (ce52448) to head (ab4e296).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #127         +/-   ##
===================================================
- Coverage   81.69858%   81.65658%   -0.04201%     
===================================================
  Files            855         856          +1     
  Lines          33899       34034        +135     
===================================================
+ Hits           27695       27791         +96     
- Misses          6204        6243         +39
Files Coverage Δ
trpc/client/service_proxy.cc 77.92553% <100.00000%> (+0.05885%) ⬆️
trpc/client/service_proxy.h 100.00000% <ø> (ø)
trpc/client/service_proxy_manager.cc 98.27586% <100.00000%> (-0.02923%) ⬇️
trpc/client/service_proxy_option_setter.cc 98.21429% <100.00000%> (+0.03247%) ⬆️
trpc/common/config/client_conf.h 100.00000% <ø> (ø)
trpc/common/config/client_conf_parser.h 100.00000% <100.00000%> (ø)
trpc/common/trpc_plugin.cc 58.40000% <100.00000%> (+0.16706%) ⬆️
trpc/server/non_rpc/non_rpc_service_impl.cc 100.00000% <ø> (ø)
...n_complex/fiber_tcp_conn_complex_connector_group.h 100.00000% <ø> (ø)
...sport/client/fiber/fiber_connector_group_manager.h 100.00000% <ø> (ø)
... and 8 more

... and 8 files with indirect coverage changes

@chhy2009
Copy link
Contributor

lgtm

@chhy2009 chhy2009 merged commit 5100aa1 into main Apr 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhy2009 chhy2009 Awaiting requested review from chhy2009

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helloopenworld @chhy2009